-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Amazon Bedrock Converse API to re-implementing Bedrock AI Models. #813
base: main
Are you sure you want to change the base?
Use Amazon Bedrock Converse API to re-implementing Bedrock AI Models. #813
Conversation
a96e2b9
to
68b544a
Compare
0efbb59
to
eeccd04
Compare
@tzolov Hi Christian, I'm basically finished re-implementing Bedrock AI models with the Amazon Bedrock Converse API. But there are some thing's I'd like to discuss.
|
eeccd04
to
49b3326
Compare
a3ad6d5
to
fde14fe
Compare
bc273da
to
6cb7439
Compare
cab722a
to
fb35a96
Compare
fb35a96
to
89f9c89
Compare
…nverseApi instead.
40930c7
to
678389f
Compare
6e3a7fa
to
2c8968d
Compare
Is it realistic to expect this PR to be merged before 1.0.0? |
I hope that, I'm looking forward to have this PR merged as soon as possible too... |
I hope so, This is a huge PR, Maybe we can review it by ourselves first to reduce the workload for the team members |
Hello @tzolov Any advice on this PR? |
e060a4d
to
0527909
Compare
Hi @maxjiang153, it's a pity that there is no news about this PR, maybe it's too big, I don't know.... Thanks all for the huge effort !! |
Hi @maxjiang153 , Thank you very much for the great (and big ;) contribution. Sorry for not reaching out earlier. We've been quite busy and lacking the manpower to review and address all PRs. The #813 has a hight priority for me and I hope to be able to jump on it soon. |
@tzolov As Amazon Bedrock is rapidly involved and the AI 21 Jamba model is just generally available, I wonder: should I keep moving on this PR to support this new model or wait for this PR to be merged and then create a new PR to support the new model? Check this out: https://aws.amazon.com/about-aws/whats-new/2024/06/ai21-labs-jamba-instruct-model-amazon-bedrock/ |
@maxjiang153 it would be great if you can update the PR with the latest changes in the project, so it can be easily reviewed by @tzolov. |
waiting .... |
@DEG-7 I see that maintaining this PR with upstream is heavy work, I'm not sure when team members will work on this PR, but I'll keep an eye out for when it will be reviewed or merged. |
Excuse me, are there any dates when this PR will be merged? |
I understand the difficulties keeping it up to date with main an appreciate the efforts. We have fallen behind in PR, in particular those around bedrock because we haven't had the time to wrap our head yet our the big changes going on. I apologize. The Alibaba models are important to the project and I do expect it to be part of the 1.0 release. I would like to make sorting out the bedrock story a priority for us after this M2 release. |
see: #809
Provide a new
BedrockConverseApi
for AI model chat usage.Re-implementing current chat models from
AbstractBedrockApi
to the Bedrock Converse API to reduce complexity.Re-implementing Bedrock chat model usage information: #605.
Support build-in exponential backoff: #759.
things todo:
BedrockRuntimeClient
andBedrockRuntimeAsyncClient
.